This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG280333021e95: [SanitizeCoverage] Add support for
NoSanitizeCoverage function attribute (authored by melver).
Repository:
rG LLVM Github Monorepo
melver added a comment.
Please have a look at the other 2 patches which are now a dependency for this.
Once you're happy with all 3 I'll push them all together.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102772/new/
melver added inline comments.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757-760
+bool HaveSanitizeCoverage =
+CGM.getCodeGenOpts().SanitizeCoverageType ||
+CGM.getCodeGenOpts().SanitizeCoverageIndirectCalls ||
+
melver updated this revision to Diff 347062.
melver marked 3 inline comments as done.
melver added a comment.
- Refactor test and SanitizeCoverage* checking.
- s/no_sanitize_coverage/nosanitize_coverage/
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
melver added inline comments.
Comment at: clang/test/CodeGen/sanitize-coverage.c:23-87
+static inline __attribute__((__always_inline__)) void always_inlined_fn(int n)
{
+ if (n)
+x[n] = 42;
+}
+// CHECK-LABEL: define dso_local void @test_always_inline(
+void
vitalybuka accepted this revision.
vitalybuka added inline comments.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757-760
+bool HaveSanitizeCoverage =
+CGM.getCodeGenOpts().SanitizeCoverageType ||
+CGM.getCodeGenOpts().SanitizeCoverageIndirectCalls ||
+
morehouse accepted this revision.
morehouse added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102772/new/
https://reviews.llvm.org/D102772
melver updated this revision to Diff 346577.
melver added a comment.
Herald added a subscriber: steven_wu.
Rest of long-tail of IR changes related to introducing a new attributes...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102772/new/
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278
if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) ==
-SanitizerMask())
+SanitizerMask() &&
+SanitizerName != "coverage")
melver
melver added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278
if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) ==
-SanitizerMask())
+SanitizerMask() &&
+SanitizerName != "coverage")
aaron.ballman
aaron.ballman added a comment.
The clang parts look good to me, but someone else should do the final sign-off.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278
if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) ==
-SanitizerMask())
+
melver updated this revision to Diff 346484.
melver added a comment.
Test that always_inline works as expected with no_sanitize("coverage")
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102772/new/
https://reviews.llvm.org/D102772
Files:
melver updated this revision to Diff 346452.
melver marked 2 inline comments as done.
melver added a comment.
Address Aaron's comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102772/new/
https://reviews.llvm.org/D102772
Files:
aaron.ballman added inline comments.
Comment at: clang/docs/SanitizerCoverage.rst:319
+It is possible to disable coverage instrumentation for select functions via the
+function attribute ``__attribute__((no_sanitize("coverage")))``.
+
I would expect to see this
melver created this revision.
melver added reviewers: vitalybuka, morehouse, glider, dvyukov.
Herald added subscribers: dexonsmith, jdoerfert, pengfei, hiraditya.
Herald added a reviewer: aaron.ballman.
melver requested review of this revision.
Herald added projects: clang, LLVM.
Herald added
15 matches
Mail list logo
