[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. This was discussed in llvm-dev mailing list, and originally we had a change that was closer to what GCC was reporting however there was no consensus on what was needed. The purpose of this change is to bring parity in terms of available options with GCC.

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

MaskRay added a comment. In D102782#2862065 , @rsanthir.quic wrote: > @MaskRay Yes this would unblock applications. Regarding your concern, the > information from this implementation as well as GCC's should be used > conservatively as both are

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. @MaskRay Yes this would unblock applications. Regarding your concern, the information from this implementation as well as GCC's should be used conservatively as both are approximate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

MaskRay added a comment. In GCC -Wstack-usage= is more powerful. It can check `warning: stack usage might be unbounded`. If this is currently just an alias, does it address some application pain? If we don't actually implement the -Wstack-usage= functionality, I'd hope that applications know

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping @Quuxplusone this is being used as a diagnostic flag that aliases "-Wframe-larger-than", I think if we want to add more user-facing documentation to clarify things we should revisit what the "-Wframe-larger-than=" tracks as well. Currently there isn't too

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added inline comments. Comment at: clang/docs/ReleaseNotes.rst:79-80 +- ``-Wstack-usage=`` warn if stack usage of user functions might + exceed . + Quuxplusone wrote: > Does this mean: > - Warn if the size of any single function's stack frame

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

Quuxplusone added inline comments. Comment at: clang/docs/ReleaseNotes.rst:79-80 +- ``-Wstack-usage=`` warn if stack usage of user functions might + exceed . + Does this mean: - Warn if the size of any single function's stack frame (including temporaries and

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. @bruno all tests are passing, could you take another look when you have a chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 349274. rsanthir.quic added a comment. Updated Release Notes and rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/docs/ReleaseNotes.rst

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348563. rsanthir.quic added a comment. Updated test and aligned negative flag with gcc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files:

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348555. rsanthir.quic added a comment. Updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/include/clang/Driver/Options.td

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348531. rsanthir.quic added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/include/clang/Driver/Options.td

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. Thanks for reviewing @bruno doesn't look like the failure is related to my change: https://buildkite.com/llvm-project/premerge-checks/builds/39905#5f70c261-ae54-451b-b771-7012bcee7387 "No space left on device" Unless I am looking at the wrong thing. Repository:

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

bruno added a comment. Overall looks good, sounds like it's failing tests though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 346582. rsanthir.quic added a comment. Localized changes to Options.td, needed to explicitly add negative flag for -Wframe-larger-than Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

apazos added inline comments. Comment at: clang/lib/Basic/Warnings.cpp:101 +Opt = "no-frame-larger-than="; + // Check to see if this warning starts with "no-", if so, this is a Since GCC supports the negative option -Wno-stack-usage, I think it is

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

dblaikie added a comment. Generally looks reasonable to me - but I'll leave signoff to some other folks who have been more involved in the discussion so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic created this revision. Herald added subscribers: dexonsmith, dang. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this implementation "-Wstack-usage" acts as an alias to "-Wframe-larger-than" Repository: