This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8f20ac9595c8: [PGO] Don't reference functions unless
value profiling is enabled (authored by rnk).
Repository:
rG LLVM Github Monorepo
CHANGES SI
vsk accepted this revision.
vsk added a comment.
Thanks, lgtm as well. On Darwin, the __llvm_prf_data section is marked with
S_ATTR_LIVE_SUPPORT to allow the linker to dead strip functions even if they
are pointed-to by a profd global. Removing the reference altogether should
yield even better
rnk added a comment.
Thanks! I'll wait to see if I can get an ack from the Apple folks who indicated
that they are using frontend PGO.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102818/new/
https://reviews.llvm.org/D102818
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm (value profiling is off by default for FE PGO anyway)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102818/new/
https://reviews.llvm.org/
rnk created this revision.
rnk added reviewers: vsk, davidxl, Bigcheese.
Herald added subscribers: wenlei, hiraditya.
rnk requested review of this revision.
Herald added projects: clang, Sanitizers, LLVM.
Herald added a subscriber: Sanitizers.
This reduces the size of chrome.dll.pdb built with opt
