This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG18c19414eb70: [PowerPC] Add PowerPC compare and multiply
related builtins and instrinsics for… (authored by NeHuang).
Changed prior to commit:
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM aside from a formatting nit.
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1574
+ : GCCBuiltin<"__builtin_ppc_cmprb">,
+
NeHuang updated this revision to Diff 358397.
NeHuang marked 4 inline comments as done.
NeHuang added a comment.
Addressed review comments from Nemanja.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102875/new/
https://reviews.llvm.org/D102875
nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.
Requesting changes to keep the queue accurate.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102875/new/
nemanjai added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9754
"this builtin is only valid on POWER7 or later CPUs">;
+def err_ppc_builtin_only_on_pwr9 : Error<
+ "this builtin is only valid on POWER9 or later CPUs">;
No
NeHuang added inline comments.
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-multiply.ll:9
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \
+; RUN: -mcpu=pwr9 < %s | FileCheck %s --check-prefix=CHECK-64
+
amyk wrote:
> Does it
NeHuang added a comment.
Need to merge with https://reviews.llvm.org/D105501 changes once approved for
pwr9 (or later processor) only sema checking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102875/new/
https://reviews.llvm.org/D102875
NeHuang added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3356
+ case PPC::BI__builtin_ppc_maddld:
+return SemaFeatureCheck(*this, TheCall, "power9-vector",
+diag::err_ppc_builtin_only_on_pwr9);
amyk wrote:
>
NeHuang updated this revision to Diff 357625.
NeHuang marked 3 inline comments as done.
NeHuang added a comment.
Address review comments on test case and remove change not needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102875/new/
amyk added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3356
+ case PPC::BI__builtin_ppc_maddld:
+return SemaFeatureCheck(*this, TheCall, "power9-vector",
+diag::err_ppc_builtin_only_on_pwr9);
This is just a
NeHuang added a comment.
gentle ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102875/new/
https://reviews.llvm.org/D102875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NeHuang updated this revision to Diff 356701.
NeHuang marked 4 inline comments as done.
NeHuang added a comment.
Address review comments on the test case. Target cpu sema checking covered in
front end test cases. will keep current coverage in backend test.
Repository:
rG LLVM Github Monorepo
amyk added inline comments.
Comment at:
llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-compare-64bit-only.ll:39
+
+attributes #0 = { noinline nounwind optnone "frame-pointer"="none"
"min-legal-vector-width"="0" "no-trapping-math"="true"
"stack-protector-buffer-size"="8"
NeHuang updated this revision to Diff 354081.
NeHuang added a comment.
- Added Sema check for the pwr9 only builtins and updated the test cases.
- Rebased the patch with ToT.
- Cleaned up the test cases and address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lei added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-compare-64bit-only.c:8
+// RUN: not %clang_cc1 -triple powerpc-unknown-aix \
+// RUN: -emit-llvm %s -o - -target-cpu pwr9 2>&1 | FileCheck %s
-check-prefix=CHECK-32
+
lei added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-compare-64bit-only.c:6
+// RUN: %clang_cc1 -triple powerpc64-unknown-aix \
+// RUN: -emit-llvm %s -o - -target-cpu pwr9 | FileCheck %s
--check-prefix=CHECK-64
+// RUN: not %clang_cc1 -triple
lei added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.h:354
- void defineXLCompatMacros(MacroBuilder ) const {
-Builder.defineMacro("__popcntb", "__builtin_ppc_popcntb");
Can you pleases rebase your patch again? The removal of this function
NeHuang updated this revision to Diff 352560.
NeHuang added a comment.
- Add AIX 32&64 bit run line checks (front and back end test cases)
- Create builtin-ppc-xlcompat-error.c for arguments related error check, add
error test case for `__builtin_ppc_cmprb`
- Remove 32 bit linux run line checks
NeHuang updated this revision to Diff 351989.
NeHuang added a comment.
Rebased the patch with changes in https://reviews.llvm.org/D104125
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102875/new/
https://reviews.llvm.org/D102875
Files:
NeHuang updated this revision to Diff 350991.
NeHuang added a comment.
- Renamed the XLCompat builtin as `__builtin_ppc_*` and add them to
`definedXLCompatMacros` and update the test cases.
- Report error in SemaChecking when 64 bit only builtins run on a 32 bit target
and update the test
NeHuang created this revision.
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai.
NeHuang requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This is patch is in a series of patches to provide builtins for
21 matches
Mail list logo
