[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 added a comment. I believe I've addressed all suggestions provided so far. @dexonsmith & @Bigcheese, can you check again? Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used:

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 updated this revision to Diff 378222. jansvoboda11 added a comment. Rebase, handle module maps, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923 Files:

[PATCH] D102923: [clang][lex] Remark for used header search paths

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:427 +def remark_pp_include_header_search_usage : Remark< + "user-provided search path used: '%0'">, + InGroup>; jansvoboda11 wrote: > dexonsmith wrote: > > I suggest,

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 added a comment. In D102923#2787702 , @dexonsmith wrote: > Yup, seems like something that could be added as a follow up (although > probably using the same remark). Is there a good place to leave behind a > FIXME? I'll put a FIXME at an

[PATCH] D102923: [clang][lex] Remark for used header search paths

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Thanks for your patience! I thought I already looked at this last week. This is looking close. Comments mostly inline, but a high level point: I think this should report

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 added a comment. In D102923#2781386 , @Bigcheese wrote: > I also wonder how we should handle other things that are found via include > paths such as module maps. That's a good point. The logic for module map lookup is more complex than

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 updated this revision to Diff 348518. jansvoboda11 added a comment. Fix naming of new functions/variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923 Files:

[PATCH] D102923: [clang][lex] Remark for used header search paths

Bigcheese added a subscriber: akyrtzi. Bigcheese added a comment. I think this is looking good, but would like either @dexonsmith, @akyrtzi, or someone else familiar with this area to take a look. Only other comment I have is that the new functions you add should use the current LLVM naming

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For dependency scanning, it would be useful to collect header search paths (provided on