[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a75c06cd9d9: [CUDA] Work around compatibility issue with libstdc++ 11.1.0 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

jwakely accepted this revision. jwakely added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:79 +#if _GLIBCXX_RELEASE == 11 +#define __failed_assertion __cuda_failed_assertion +#endif yaxunl wrote: > May I ask where is __cuda_failed_assertion defined? Thanks. The function is

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

yaxunl added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:79 +#if _GLIBCXX_RELEASE == 11 +#define __failed_assertion __cuda_failed_assertion +#endif May I ask where is __cuda_failed_assertion defined? Thanks. Repository: rG LLVM

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added a comment. In D102936#2774686 , @jwakely wrote: > You can't use `__GLIBCXX__` this way. It will be different for different > snapshots from the gcc-11 branch. Some distros are already shipping gcc-11 > snapshots with later dates. > > I would

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra updated this revision to Diff 347133. tra added a comment. Check only _GLIBCXX_RELEASE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 Files: clang/lib/Headers/cuda_wrappers/complex Index:

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

jwakely requested changes to this revision. jwakely added a comment. This revision now requires changes to proceed. You can't use `__GLIBCXX__` this way. It will be different for different snapshots from the gcc-11 branch. I would just check RELEASE == 11. If `__failed_assertion` is present,

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

fodinabor accepted this revision. fodinabor added a comment. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 ___ cfe-commits mailing list

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:77 +// https://bugs.llvm.org/show_bug.cgi?id=50383 +#pragma push_macro("__failed_assert") +#if _GLIBCXX_RELEASE == 11 && __GLIBCXX__ == 20210427 tra wrote: > fodinabor wrote: > > Not

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra updated this revision to Diff 347092. tra edited the summary of this revision. tra added a comment. Fixed typo in push/pop macro name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 Files:

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:77 +// https://bugs.llvm.org/show_bug.cgi?id=50383 +#pragma push_macro("__failed_assert") +#if _GLIBCXX_RELEASE == 11 && __GLIBCXX__ == 20210427 fodinabor wrote: > Not sure I

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

fodinabor added a comment. Sadly don't have stdibc++11 available locally as well.. so can't verify, but looks good to me except for the push and pop macros. Comment at: clang/lib/Headers/cuda_wrappers/complex:77 +// https://bugs.llvm.org/show_bug.cgi?id=50383 +#pragma

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra created this revision. tra added reviewers: jlebar, jwakely. Herald added subscribers: bixia, yaxunl. tra requested review of this revision. Herald added a project: clang. libstdc++ 11.1.0 redeclares __failed_assertion multiple times and that results in the function declared with conflicting