[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-09-04 Thread lin.sun via Phabricator via cfe-commits
sunlin abandoned this revision. sunlin added a comment. Close it for ignore these headers from command line. It is included from chain: "include/clang/Basic/TargetBuiltins.h" --> "clang/Basic/BuiltinsARM.def" --> "include/clang/Basic/arm_cde_builtins.inc"... Repository: rG LLVM Github

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-06-01 Thread lin.sun via Phabricator via cfe-commits
sunlin added a comment. Yes, a CMake option is a good idea for this. I'll update this change to add a new CMake option for who don't want all the headers (default OFF to follow exist behavior) . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-06-01 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. I think I'm fine with the general direction, but it would be nice to have a CMake option to force the headers for all targets to be built if someone needs them. For static analysis or something like that, I can imagine someone building LLVM without any backends at

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-06-01 Thread Momchil Velikov via Phabricator via cfe-commits
chill added a comment. IMHO, it's possible to write a frontend test, which includes, say `arm_neon.h`, but does not really require the `ARM` or `AArch64` backends to be configured (e.g. `CodeGen/arm-vector-align.c`?) If `arm_neon.h` is not built, then the test would need the appropriate

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-06-01 Thread Kristof Beyls via Phabricator via cfe-commits
kristof.beyls added a comment. In D103080#2790139 , @sunlin wrote: > Hi @kristof.beyls The original `lib/clang/12.0.1/include` is about total > ~10M, and the `arm*.h` take about ~5M. Ignore these unused header files will > save the developers who work

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-05-31 Thread lin.sun via Phabricator via cfe-commits
sunlin added a comment. Hi @kristof.beyls The original `lib/clang/12.0.1/include` is about total ~10M, and the `arm*.h` take about ~5M. Ignore these unused header files will save the developers who work on the low storage device. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-05-31 Thread Kristof Beyls via Phabricator via cfe-commits
kristof.beyls added a comment. I'm wondering what the rationale for this change is. If there is a good rationale for this; wouldn't it need to be applied to all target-specific header files, not only the Arm-specific header files? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-05-25 Thread lin.sun via Phabricator via cfe-commits
sunlin created this revision. Herald added subscribers: kristof.beyls, mgorny. sunlin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Copy the arm_*.h files only "ARM" is in build targets. Repository: rG LLVM Github Monorepo