[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

2021-07-08 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover closed this revision. t.p.northover added a comment. Thanks Duncan, committed as 727e1c9be3a5 Comment at: llvm/include/llvm/Support/thread.h:107 + + bool joinable() const noexcept { +retur

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

2021-07-06 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, with some whitespace nits inline. In D103165#2790932 , @t.p.northover wrote: >> Also this way llvm::thread users that don't need f

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

2021-07-06 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103165/new/ https://reviews.llvm.org/D103165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

2021-06-01 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added inline comments. Comment at: llvm/include/llvm/Support/thread.h:168 +/// stack size request. +class thread { +public: An alternative here would have been to inherit from `std::thread` but that seemed a bit icky to me. Happy to switch if the c

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

2021-06-01 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover updated this revision to Diff 348958. t.p.northover added a comment. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, hiraditya. Herald added a project: clang-tools-extra. - Add `llvm::thread` for all potential platforms, allowing stack size to be specified. - `