[PATCH] D103286: [clang-format] Add PPIndentWidth option

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f605b8d0bc1: [clang-format] Add PPIndentWidth option (authored by gergap, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D103286?vs=348955=349569#toc Repository:

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2674 + /// \endcode + signed PPIndentWidth; + I've replaced this with `int`, because `signed` results in an exception from `dump_format_style.py`. Repository: rG

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348955. gergap added a comment. trigger build again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap added a comment. @HazardyKnusperkeks could you please land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 ___ cfe-commits mailing list

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348794. gergap added a comment. changed wording as requested and updated release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files:

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good to me, I would just change the wording a bit. Could you please also add a entry in the ReleaseNotes.rst? Comment at:

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348753. gergap marked an inline comment as done. gergap added a comment. fix review findings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files:

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap marked 3 inline comments as done. gergap added a comment. I fixed the review findings and changed the behavior to be better backwards compatible by using PPIndentWidth=-1 by default. This value defaults to IndentWidth now. Comment at:

[PATCH] D103286: [clang-format] Add PPIndentWidth option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3447 + style); +} + can you add a test ``` #ifdef X void foo() { ... } #endif ``` its unclear if PPIndentWidth affects code in #ifdef or just #

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2336 + /// \endcode + unsigned PPIndentWidth; + I prefer alphabetical sorting, I know there are some entries which aren't sorted. Repository: rG LLVM Github Monorepo

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Love it! But this will result in unexpected (one might say breaking) behaviour, if someone set `IndentWidth` to a different value than his base style and

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348453. gergap added a comment. fixing test issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap created this revision. gergap added reviewers: klimek, Richard. Herald added a subscriber: krytarowski. gergap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows to set a different indent width for preprocessor statements.