[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-04 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG21c18d5a0431: [Format] Fix incorrect pointer detection (authored by Nuu, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-03 Thread Yilong Guo via Phabricator via cfe-commits
Nuu added a comment. In D103589#2796032 , @curdeius wrote: > LGTM. Thanks for fixing this! > Do you have commit rights or you need somebody to land it for you? I don't have commit access. I'd appreciate it if you or someone else could land this

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-03 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Do you have commit rights or you need somebody to land it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-03 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Seems reasonable. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103589/new/ https://reviews.llvm.org/D103589 ___

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Yilong Guo via Phabricator via cfe-commits
Nuu added a comment. In D103589#2795447 , @curdeius wrote: > Thanks for looking into this, but please add a test case that demonstrates > the bug to `FormatTests.cpp` > Also, is there, by any chance, an associated bugzilla ticket? Thanks for the

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Yilong Guo via Phabricator via cfe-commits
Nuu updated this revision to Diff 349455. Nuu edited the summary of this revision. Nuu added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103589/new/ https://reviews.llvm.org/D103589 Files:

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for looking into this, but please add a test case that demonstrates the bug to `FormatTests.cpp` Also, is there, by any chance, an associated bugzilla ticket?

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Yilong Guo via Phabricator via cfe-commits
Nuu created this revision. Nuu added a project: clang-format. Nuu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before: void foo() { bar(float(1), a *b); } After: void foo() { bar(float(1), a * b); } Signed-off-by: