[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

Matt added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:161 EnableBranchTargets("aarch64-enable-branch-targets", cl::Hidden, cl::desc("Enable the AAcrh64 branch target pass"),

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith added a comment. Yup, just committed a fix in ed31ff9c7a9e538ead1fa4feecf09987998621b4 , sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103702/new/

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

FlameTop added a comment. This commit is failing the test on non-arm targets (e.g. https://lab.llvm.org/buildbot/#/builders/139/builds/5932). I think the test needs a 'requires' line for aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e7329e37ede: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries (authored by bsmith). Changed prior to commit: https://reviews.llvm.org/D103702?vs=352101=353345#toc

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

paulwalker-arm accepted this revision. paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:350-352 unsigned AArch64Subtarget::getMaxSVEVectorSizeInBits() const { assert(HasSVE && "Tried to get SVE vector length without SVE

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:298-299 + bool LittleEndian, + unsigned MinSVEVectorSizeInBitsOverride = 0, + unsigned MaxSVEVectorSizeInBitsOverride = 0);

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith updated this revision to Diff 352101. bsmith marked an inline comment as done. bsmith added a comment. - Ensure user input is sanitized for when asserts are not enabled - Fix clang format issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:298-299 + bool LittleEndian, + unsigned MinSVEVectorSizeInBitsOverride = 0, + unsigned MaxSVEVectorSizeInBitsOverride = 0);

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:226 + : SVEVectorBitsMaxOpt), TargetTriple(TT), FrameLowering(), InstrInfo(initializeSubtargetDependencies(FS, CPU)), TSInfo(),

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith updated this revision to Diff 351910. bsmith marked 7 inline comments as done. bsmith added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Move attribute/command line logic into AArch64TargetMachine. - Fix issue with subtarget key appending integers. -