[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

2021-06-20 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe37653da1399: [clangd] Type hints for C++14 return type deduction (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103789/new/

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

2021-06-14 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 351788. nridge added a comment. Put hint in trailing return type position Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103789/new/ https://reviews.llvm.org/D103789 Files:

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

2021-06-14 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:79 + if (!Deduced.isNull()) { +SourceRange R = D->getReturnTypeSourceRange(); +// For operator auto(), have to get location of `auto` a different way.

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

2021-06-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:79 + if (!Deduced.isNull()) { +SourceRange R = D->getReturnTypeSourceRange(); +// For

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

2021-06-07 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM