[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rGf664e2ec371f: Thread safety analysis: Always warn when dropping locks on back edges (authored by

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

rupprecht added a comment. In D104261#2844636 , @aaronpuchert wrote: > In D104261#2841356 , @delesley > wrote: > >> since it's restricted to relockable managed locks, I'm not too worried... > > Not quite, it

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added a subscriber: rupprecht. aaronpuchert added a comment. In D104261#2841356 , @delesley wrote: > since it's restricted to relockable managed locks, I'm not too worried... Not quite, it affects scoped locks with explicit unlock, which

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

delesley accepted this revision. delesley added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for the patch! Since you're adding a new warning, this may break some code somewhere, but since it's restricted to relockable managed locks, I'm not too

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:868 ThreadSafetyHandler ) const override { -if (!managed() && !asserted() && !negative() && !isUniversal()) { +if (!asserted() && !negative() &&

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added a comment. In D104261#2832892 , @aaron.ballman wrote: > I think the CI failure (libarcher.races::lock-unrelated.c) is not related to > this patch but is a tsan thing, but you may want to double-check that just in > case. Seems that

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaron.ballman added a comment. I think the CI failure (libarcher.races::lock-unrelated.c) is not related to this patch but is a tsan thing, but you may want to double-check that just in case. I think this looks reasonable, but I'd like to hear from @delesley before landing.

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2227-2228 /// \param LEK2 The error message to report if a mutex is missing from Lset2 void ThreadSafetyAnalyzer::intersectAndWarn(FactSet , const

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:868 ThreadSafetyHandler ) const override { -if (!managed() && !asserted() && !negative() && !isUniversal()) { +if (!asserted() && !negative() &&

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We allow branches to join where one holds a managed lock but the other doesn't, but we