On Mon, Aug 17, 2015 at 9:24 AM, Nico Weber tha...@chromium.org wrote:
thakis added a subscriber: thakis.
Comment at: lib/Driver/Tools.cpp:398
@@ +397,3 @@
+ FoundPTH = !UsePCH;
+}
+ }
kimgr wrote:
kimgr wrote:
On Tue, Aug 18, 2015 at 2:00 AM, Richard Smith rich...@metafoo.co.uk wrote:
Should this logic for PCH/PTH scanning move out of the driver and into
the frontend?
gcc also checks if the gch file is a directory and if so finds the first
file with matching language / defines etc. It also uses
thakis added a subscriber: thakis.
Comment at: lib/Driver/Tools.cpp:398
@@ +397,3 @@
+ FoundPTH = !UsePCH;
+}
+ }
kimgr wrote:
kimgr wrote:
kimgr wrote:
kimgr wrote:
Add a `break;` here so we don't continue searching
kimgr added inline comments.
Comment at: lib/Driver/Tools.cpp:398
@@ +397,3 @@
+ FoundPTH = !UsePCH;
+}
+ }
kimgr wrote:
kimgr wrote:
kimgr wrote:
Add a `break;` here so we don't continue searching after a valid path has
