[PATCH] D104804: [AMDGPU] Add gfx1035 target

jhenderson added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:189 +# RUN: sed -e 's//64/' -e 's//AMDGCN_GFX1035/' %s | yaml2obj -o %t.o.AMDGCN_GFX1035 +# RUN: llvm-readobj -S --file-headers %t.o.AMDGCN_GFX1035 | FileCheck

[PATCH] D104804: [AMDGPU] Add gfx1035 target

MaskRay added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:189 +# RUN: sed -e 's//64/' -e 's//AMDGCN_GFX1035/' %s | yaml2obj -o %t.o.AMDGCN_GFX1035 +# RUN: llvm-readobj -S --file-headers %t.o.AMDGCN_GFX1035 | FileCheck

[PATCH] D104804: [AMDGPU] Add gfx1035 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3453f3dd46f5: [AMDGPU] Add gfx1035 target (authored by aakanksha555). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 added a comment. In D104804#2838883 , @foad wrote: > Looks OK. Have you run check-llvm and check-clang? I did, no other failing tests observed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104804: [AMDGPU] Add gfx1035 target

foad added a comment. Looks OK. Have you run check-llvm and check-clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https://reviews.llvm.org/D104804 ___ cfe-commits mailing list

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 updated this revision to Diff 354270. aakanksha555 marked 4 inline comments as done. aakanksha555 added a comment. Addressed feedback; fixed typo and missing check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/

[PATCH] D104804: [AMDGPU] Add gfx1035 target

foad added inline comments. Comment at: clang/test/Driver/amdgpu-mcpu.cl:138 // GFX1034: "-target-cpu" "gfx1034" +// GFX1034: "-target-cpu" "gfx1035" Typo in check prefix. Why didn't this make the test fail? Comment at:

[PATCH] D104804: [AMDGPU] Add gfx1035 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https://reviews.llvm.org/D104804

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 created this revision. aakanksha555 added reviewers: kzhuravl, msearles, rampitec. Herald added subscribers: foad, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, emaste, arsenm, jholewinski. Herald added a reviewer: jhenderson. Herald