[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

2021-07-16 Thread Lei Huang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35a18a981f6b: [PowerPC] Implement intrinsics for mtfsf[i] (authored by nemanjai, committed by lei). Changed prior to commit: https://reviews.llvm.

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

2021-07-16 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1589 [IntrNoMem, IntrHasSideEffects]>; def int_ppc_mtfsfi : GCCBuiltin<"__builtin_ppc_mtfsfi">, qiucf wrote: > If `mtfsf` was changed, `mtfsfi` `mt

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

2021-07-14 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. The PPC instructions tablegen part looks good to me. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1589 [IntrNoMem, IntrHasSideEffects]>; def int

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

2021-07-13 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:4484 +// as an implicit def for all of them. +let Predicates = [HasFPU] in { +let Defs = [RM] in { @ZhangKang You modified this code most recently. Please provide your opinion he

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

2021-07-13 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai created this revision. nemanjai added reviewers: PowerPC, ZhangKang. Herald added subscribers: shchenz, kbarton, hiraditya. nemanjai requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This provides intrinsics for emitting instruc