[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha abandoned this revision. SaurabhJha added a subscriber: Florian. SaurabhJha added a comment. > @SaurabhJha did you ever get a chance to create a patch? Hey @Florian, sorry I dropped the ball here. I don't think I would be able to spend time on this so abandoning this revision.

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. Herald added a project: All. In D106005#2904865 , @SaurabhJha wrote: > In D106005#2904424 , @fhahn wrote: > >> In D106005#2896080 , @SaurabhJha

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added a comment. In D106005#2904424 , @fhahn wrote: > In D106005#2896080 , @SaurabhJha > wrote: > >> In D106005#2895716 , @fhahn wrote: >> >>> Thank you very

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. In D106005#2896080 , @SaurabhJha wrote: > In D106005#2895716 , @fhahn wrote: > >> Thank you very much for working on this! Are you planning on implementing >> the new specification as

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha updated this revision to Diff 360886. SaurabhJha added a comment. Add documentation for matrix broadcast initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 Files:

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added a comment. In D106005#2895716 , @fhahn wrote: > Thank you very much for working on this! Are you planning on implementing the > new specification as well? It would probably be good to land the update to > the spec in close succession

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. Thank you very much for working on this! Are you planning on implementing the new specification as well? It would probably be good to land the update to the spec in close succession to the implementation, to avoid confusing users. Comment at:

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha updated this revision to Diff 360716. SaurabhJha added a comment. Address second round of comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 Files: clang/docs/MatrixTypes.rst Index:

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:279 +The number of constituent arrays must equal the number rows in the matrix type M and the number of elements +in each constituent array must equal the number of columns in the matrix type. +

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:279 +The number of constituent arrays must equal the number rows in the matrix type M and the number of elements +in each constituent array must equal the number of columns in the matrix type. +

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha updated this revision to Diff 360524. SaurabhJha added a comment. Updated docs to address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 Files: clang/docs/MatrixTypes.rst Index:

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + SaurabhJha wrote: > fhahn wrote: > > is there a reason we need to allow 'empty'

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + fhahn wrote: > is there a reason we need to allow 'empty' initialisation? What does it

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + is there a reason we need to allow 'empty' initialisation? What does it mean? Repository:

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha created this revision. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As part of https://bugs.llvm.org/show_bug.cgi?id=46251, this patch adds definition of matrix initialisation. I am not very familiar with this