[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd1520247de: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D106130?

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

lei added inline comments. Comment at: llvm/test/CodeGen/builtins-ppc-xlcompat-move-tofrom-regs.ll:3 +; NOTE: Had to manually modify the last test case (mtmsr) to allow the +; NOTE: common check of mtmsr instead of 4 different check prefixes ; RUN: llc -verify-machineinstrs -mtr

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 __

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap updated this revision to Diff 359424. Conanap added a comment. added an error test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Ba

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

nemanjai added a comment. Could you please add a check for constant arguments to `clang/test/CodeGen/builtins-ppc-xlcompat-error.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 __

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15586 + case PPC::BI__builtin_ppc_mfspr: { +llvm::Type *RetType = CGM.getDataLayout().getTypeSizeInBits(VoidPtrTy) == 32 + ? Int32Ty nemanjai wrote: > Is

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap updated this revision to Diff 359400. Conanap marked 4 inline comments as done. Conanap added a comment. Changed `i32` to `timm` for patterns, some nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Why does this review have no reviewers listed? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15586 + case PPC::BI__builtin_ppc_mfspr: { +llvm::Type *RetType

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap updated this revision to Diff 359236. Conanap added a comment. Added sema checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Ba

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Implemented builtins for mtmsr, mfspr, mtspr on PowerPC;