[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4ed93cb25ac: [PowerPC] Implement XL compatible behavior of __compare_and_swap (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. > that looks like a historical issue which exists for 13yrs Hmm... OK.. Let us leave it as it is for now. Thanks for the new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail updated this revision to Diff 360721. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106344/new/ https://reviews.llvm.org/D106344 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-ppc-xlcompat-cas.c

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail updated this revision to Diff 360699. lkail added a comment. Herald added a project: LLVM. Discussed with @jsji about the details of codegen and inspect XL's codegen at different opt level, add an `opt` test from jinsong to demonstrate the store can be eliminated. Repository: rG LLVM

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail added a comment. In D106344#2894755 , @jsji wrote: > Doesn't look good enough to me, the assembly code sequence generated is not > clean enough. I'm assuming you mean the second `stdcx.`, that looks like a historical issue which exists for

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

jsji added a comment. Doesn't look like good enough to me, the code sequence generated is not clean enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106344/new/ https://reviews.llvm.org/D106344