AndreyChurbanov added inline comments.
Comment at: openmp/runtime/src/dllexports:553
+omp_get_interop_ptr 761
+omp_get_interop_str 762
mstorsjo wrote:
> mstorsjo wrote:
> > jdoerfert wrote:
> > > Those values are
mstorsjo added inline comments.
Comment at: openmp/runtime/src/dllexports:553
+omp_get_interop_ptr 761
+omp_get_interop_str 762
mstorsjo wrote:
> jdoerfert wrote:
> > Those values are taken by now, you need new
mstorsjo added inline comments.
Comment at: openmp/runtime/src/dllexports:553
+omp_get_interop_ptr 761
+omp_get_interop_str 762
jdoerfert wrote:
> Those values are taken by now, you need new values that are not
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf44e41af4121: Runtime for Interop directive (authored by
sriharikrishna, committed by tianshilei1992).
Repository:
rG LLVM Github Monorepo
tianshilei1992 updated this revision to Diff 403750.
tianshilei1992 added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106674/new/
https://reviews.llvm.org/D106674
Files:
openmp/libomptarget/include/interop.h
RaviNarayanaswamy accepted this revision.
RaviNarayanaswamy added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106674/new/
https://reviews.llvm.org/D106674
sriharikrishna marked 3 inline comments as done.
sriharikrishna added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:239-242
+ if (interop_val->interop_type == kmp_interop_type_tasksync) {
+__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list,
sriharikrishna updated this revision to Diff 381801.
sriharikrishna marked 16 inline comments as done.
sriharikrishna added a comment.
Runtime for Interop directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106674/new/
sriharikrishna updated this revision to Diff 381800.
sriharikrishna added a comment.
Runtime for Interop directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106674/new/
https://reviews.llvm.org/D106674
Files:
sriharikrishna marked an inline comment as not done.
sriharikrishna added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:198-201
+ if (interop_type == kmp_interop_type_tasksync) {
+__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias,
+
RaviNarayanaswamy added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:198-201
+ if (interop_type == kmp_interop_type_tasksync) {
+__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias,
+ noalias_dep_list);
+ }
jdoerfert added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:198-201
+ if (interop_type == kmp_interop_type_tasksync) {
+__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias,
+ noalias_dep_list);
+ }
RaviNarayanaswamy added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:198-201
+ if (interop_type == kmp_interop_type_tasksync) {
+__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias,
+ noalias_dep_list);
+ }
jdoerfert added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:198-201
+ if (interop_type == kmp_interop_type_tasksync) {
+__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias,
+ noalias_dep_list);
+ }
RaviNarayanaswamy added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:198-201
+ if (interop_type == kmp_interop_type_tasksync) {
+__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias,
+ noalias_dep_list);
+ }
jdoerfert added a comment.
We need a runtime test.
Synchronizing the asyn info object and signal out dependences will happen in
the next revision.
So will minor edits as requested.
I commented below on some things.
Comment at: openmp/libomptarget/src/interop.cpp:13
+static
RaviNarayanaswamy added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:194-196
+ if (device_id == -1) {
+device_id = omp_get_default_device();
+ }
Need to check if device is available for all 3 __tgt_interop_init/use/destroy
tianshilei1992 added inline comments.
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:1150-1156
+ CUresult Err = cuDeviceGet(, DeviceId);
+ if (Err == CUDA_SUCCESS) {
+DeviceInfo->Device = reinterpret_cast(Dev);
+ } else {
+
sriharikrishna updated this revision to Diff 362524.
sriharikrishna added a comment.
Runtime for Interop directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106674/new/
https://reviews.llvm.org/D106674
Files:
tianshilei1992 added inline comments.
Comment at: openmp/libomptarget/src/interop.cpp:13
+static omp_interop_rc_t
+__kmpc_interop_get_property_err_type(omp_interop_property_t property) {
+ switch (property) {
tianshilei1992 wrote:
> There are some conventions
sriharikrishna updated this revision to Diff 362280.
sriharikrishna added a comment.
Runtime for Interop directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106674/new/
https://reviews.llvm.org/D106674
Files:
sriharikrishna updated this revision to Diff 362269.
sriharikrishna added a comment.
Runtime for Interop directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106674/new/
https://reviews.llvm.org/D106674
Files:
sriharikrishna updated this revision to Diff 362266.
sriharikrishna added a comment.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
Runtime for Interop directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
23 matches
Mail list logo
