[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck abandoned this revision. frasercrmck added a comment. Herald added a subscriber: luke. Superseded by D139873 amongst others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107290/new/

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

reames added a comment. Herald added subscribers: sunshaoce, StephenFan, arichardson. Herald added a project: All. Not knowing about this patch, I posted D135894 which addresses a small sub-set of this. If that goes in, I plan to iterative split off some

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } frasercrmck wrote: > khchen wrote: > > frasercrmck wrote: > > > khchen

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101 + } else { +RVVBitsMin = RVVVectorBitsMinOpt; +RVVBitsMax = RVVVectorBitsMaxOpt; craig.topper wrote: > frasercrmck wrote: > > frasercrmck wrote: > > >

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck updated this revision to Diff 404016. frasercrmck added a comment. rebase check for zvl feature strings alongside vscale_range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107290/new/ https://reviews.llvm.org/D107290 Files:

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:99 + if (VScaleRangeAttr.isValid()) { +RVVBitsMin = VScaleRangeAttr.getVScaleRangeMin() * RISCV::RVVBitsPerBlock; +if (VScaleRangeAttr.getVScaleRangeMax().hasValue())

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck added a comment. In D107290#3268949 , @paulwalker-arm wrote: > Does this mean `RISCVTTIImpl::getMaxVScale()` can be removed? Good question. I'm unsure at this stage. At hinted at in the description, `getMaxVScale` can make use of

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } frasercrmck wrote: > khchen wrote: > > I'm thinking do we need to test

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

paulwalker-arm added a comment. Does this mean `RISCVTTIImpl::getMaxVScale()` can be removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107290/new/ https://reviews.llvm.org/D107290 ___ cfe-commits

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } khchen wrote: > I'm thinking do we need to test zvl and

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } I'm thinking do we need to test zvl and vscale_range in the same