kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107430/new/
https://reviews.llvm.org/D107430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kiranchandramohan added a comment.
Thanks @peixin. I am going through the patch today and will accept or provide
some comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107430/new/
https://reviews.llvm.org/D107430
___
cfe-commits
peixin added a comment.
Here is the PR for codegen of ordered construct for LLVM Flang:
https://github.com/flang-compiler/f18-llvm-project/pull/1027.
I create the PR on fir-dev branch since the test of lowering parse-tree to MLIR
for LLVM Flang is still not supported in upstream llvm-project.
peixin added a comment.
@Meinersbur Thanks a lot for your review and accepting this patch.
BTW, I finished the implementation of the codegen of ordered construct for LLVM
Flang and the OpenMP IRBuilder of ordered construct in this patch also works
well for LLVM Flang. Is it OK to land this
Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
Accepting patch since no reaction from @fghanim
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107430/new/
https://reviews.llvm.org/D107430
Meinersbur added a comment.
Note that the `OpenMPIRBuilderTest.OrderedDirective` test is still crashing.
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2156-2157
+
+ Value *EntryBBTI = EntryBB->getTerminator();
+ EXPECT_EQ(EntryBBTI, nullptr);
+
peixin added a comment.
@Meinersbur Thanks for your review and suggestions.
> While manually editing `ordered_codegen.cpp` gives nicer results, re-running
> `update_cc_test_checks.py` would be less work. Your manual changes would be
> also be dropped the next time somebody runs
