This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rG2ff7ca98a99b: [clangd] Avoid expected one compiler
job by picking the first eligible job. (authored by sammccall).
Changed prior to commit:
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Compiler.cpp:42
const clang::Diagnostic ) {
+ DiagnosticConsumer::HandleDiagnostic(DiagLevel, Info);
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/Compiler.cpp:42
const clang::Diagnostic ) {
+
sammccall updated this revision to Diff 364832.
sammccall added a comment.
add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107632/new/
https://reviews.llvm.org/D107632
Files:
clang-tools-extra/clangd/Compiler.cpp
sammccall updated this revision to Diff 364829.
sammccall added a comment.
Herald added a subscriber: mgorny.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107632/new/
https://reviews.llvm.org/D107632
Files:
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang/lib/Frontend/CreateInvocationFromCommandLine.cpp:92
- const driver::Command = cast(*Jobs.begin());
- if (StringRef(Cmd.getCreator().getName()) != "clang") {
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/CompilerTests.cpp:59
+
+TEST(BuildCompilerInvocation, MultiArch) {
+ TestTU TU = TestTU::withHeaderCode(R"cpp(
maybe move this test to `clang/unittests/Frontend/ASTUnitTest.cpp`?
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
This happens in
