[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-09-27 Thread Ahsan Saghir via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG593b074a096c: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc… (authored by saghir). Repository: rG LLVM Github Monorepo

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-09-27 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 375443. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-09-23 Thread Lei Huang via Phabricator via cfe-commits
lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM once the code is simplified as Nemanja suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-09-22 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. LGTM other than the code can be simplified as suggested. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15888-15895 +SmallVector RevOps; +unsigned NumVecs = +(BuiltinID ==

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-09-12 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 372149. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-09-02 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. There are some questions to answer here before proceeding: 1. Why do we not get paired vector loads and stores in the back end test cases for either little or big endian and

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-08-26 Thread Lei Huang via Phabricator via cfe-commits
lei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15833 + // without the need for the programmer to swap operands. + if (IsLE) { +SmallVector RevOps; doesn't look like we need the interm var `IsLE`. Just use the call

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-08-23 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 368176. saghir added a comment. Added comments, and re-organized tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files:

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

2021-08-23 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 368109. saghir added a comment. Added some more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def