This revision was automatically updated to reflect the committed changes.
Closed by commit rGee620b1743bc: [clang][Arm] Fix the default floating point
ABI for (authored by sarahpurohit, committed by ahatanak).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sarahpurohit updated this revision to Diff 366179.
sarahpurohit added a comment.
Resolved syntax error with braces. No functional change otherwise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107939/new/
https://reviews.llvm.org/D107939
Files:
sarahpurohit accepted this revision.
sarahpurohit added a comment.
I do not have commit access. Can someone pull this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107939/new/
https://reviews.llvm.org/D107939
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:319
+// "apcs-gnu".
+if (Triple.isOSBinFormatMachO() && !useAAPCSForMachO(Triple)) {
+ return