[PATCH] D108045: [clangd] Fix clangd crash when including a header

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4a1686d7c4: [clangd] Fix clangd crash when including a header (authored by qdelacru, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru added a comment. Yes please land this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108045: [clangd] Fix clangd crash when including a header

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks a lot, LGTM! Do you want me to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 372005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/Preamble.cpp

[PATCH] D108045: [clangd] Fix clangd crash when including a header

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:148 bool operator==(const TextualPPDirective ) const { -return std::tie(DirectiveLine, Text) == - std::tie(RHS.DirectiveLine, RHS.Text); +return std::tie(DirectiveLine, Text,

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 369581. qdelacru added a comment. Create macro directive only preamble patch for code completion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D108045: [clangd] Fix clangd crash when including a header

kadircet added a comment. Thanks, I can see the problem now (sorry for the late reply, i was on leave last week). It is amazing that this hasn't bitten us yet during code complete flow (it probably did, but clangd would recover after restart so probably people didn't notice). I still don't

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 366358. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru created this revision. qdelacru added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. qdelacru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes