[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

2022-11-24 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. I proposed the D138657 and D138659 patches for getting rid of this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108230/new/ https://reviews.llvm

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

2022-11-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D108230#3942374 , @xazax.hun wrote: > I am a bit conflicted. It is unfortunate that C and C++ compilers regarded > single element array members as flexible array members. On the other hand, > looking at GCC, it recently adde

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

2022-11-21 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I am a bit conflicted. It is unfortunate that C and C++ compilers regarded single element array members as flexible array members. On the other hand, looking at GCC, it recently added -fstrict-flex-arrays=2

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

2022-11-17 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Herald added a project: All. I did some extensive measurements of this option. According to my results, we could confidently enable this option by default; but still, keep the flag for backward compatibility and enable the users to opt-out. The benefit of enabling this

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

2021-09-04 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG91c07eb8ee6e: [analyzer] Ignore single element arrays in getStaticSize() conditionally (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM