[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66c6bbe7ff56: Put code that avoids heapifying local blocks behind a flag (authored by waltl). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372383. waltl added a comment. Mark new option as NoDriverOption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

jyknight accepted this revision. jyknight added inline comments. Comment at: clang/include/clang/Driver/Options.td:2380 + NegFlag, + BothFlags<[CC1Option], " to avoid heapifying local blocks">>; Needs to be marked `[CC1Option, NoDriverOption]` Repository:

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl added a comment. In D108243#2998077 , @ahatanak wrote: > I was just asking for test cases as I thought it was already a driver option, > but it turns out it wasn't. I agree that this shouldn't be a driver option. > > Sorry @waltl, please revert

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372306. waltl added a comment. Remove driver flags and corresponding tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files:

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

ahatanak added a comment. I was just asking for test cases as I thought it was already a driver option, but it turns out it wasn't. I agree that this shouldn't be a driver option. Sorry @waltl, please revert the changes that made it a driver option in the last patch. Repository: rG LLVM

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

jyknight added a comment. In D108243#2995898 , @waltl wrote: > Added driver flags, and tests for them @ahatanak did you intend to ask Walt to add a driver flag for this? I think we should not have one, since this isn't something we should be telling

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372056. waltl added a comment. Added driver flags, and tests for them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files:

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. Can you add a driver test, which tests both `-fobjc-avoid-heapify-local-blocks` and `-fno-objc-avoid-heapify-local-blocks`? Other than that, LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372035. waltl added a comment. Trivial cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372031. waltl edited the summary of this revision. waltl added a comment. Merge arc-blocks-avoid-heapify.m into arc-blocks.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/