[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG1131b1eb3509: [clang][Fuchsia] Support availability attr on Fuchsia (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378784. haowei added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378780. haowei added a comment. Fix test failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/LangOptions.def:432 +VALUE_LANGOPT(FuchsiaAPILevel, 32, 0, "Fuchsia API Level") + Comment at

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378324. haowei added a comment. Added unit test when "-ffuchsia-api-level" is supplied with a non integer value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files:

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei added a comment. I added unit test for macros. I am still working on adding error checks on `--ffuchsia-api-level` flags but the rest is pretty much done. Comment at: clang/test/Frontend/attr-availability-fuchsia.c:4 +// +// It should also be exposed to non-fuchsia plat

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378052. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cla

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; haowei wrote: > ph

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; -

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377726. haowei marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/D

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

phosek added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; aaron.ballman wrote: > I

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3557 +def warn_availability_fuchsia_unavailable_minor : Warning< + "Fuchsia API Level only support 'major', not '.minor[.subminor]'">, + InGroup; ==

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377389. haowei edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basi

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei commandeered this revision. haowei added a reviewer: leonardchan. haowei added a comment. Herald added a subscriber: abrachet. I am commandeering this work as original author stopped working this project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

aaron.ballman added inline comments. Comment at: clang/test/Frontend/attr-availability-fuchsia.c:2 +// Test that `-mfuchsia-version` is propagated to cc1. +// RUN: %clang -target x86_64-unknown-fuchsia -mfuchsia-version=16 -c %s -### |& FileCheck %s +// Is `|&`

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

phosek added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:431 +VALUE_LANGOPT(FuchsiaVersion, 32, 0, "Fuchsia Version") + This is more consistent with other options. Comment at: clang/lib/Basic/Targets/OSTargets.h:888