[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

2021-09-10 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe08911e17b2b: [clang][tooling] Accept custom diagnostic options in ToolInvocation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

2021-09-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. In D108976#2979598 , @jansvoboda11 wrote: > Tests that cover this functionality were moved into a follow-up patch D108974 > . The reason is to avoid

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

2021-09-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D108976#2979867 , @arphaman wrote: > Could you add a test case for this change? Maybe a unit test? Ah I see, you mentioned that the tests are in a follow-up patch. Sorry about that. Repository: rG LLVM Github Monorepo

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

2021-09-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Could you add a test case for this change? Maybe a unit test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108976/new/ https://reviews.llvm.org/D108976 ___ cfe-commits mailing

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

2021-09-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Tests that cover this functionality were moved into a follow-up patch D108974 . The reason is to avoid temporary regression pointed out here . Repository: rG LLVM Github Monorepo