This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8b3d944a97cc: [PowerPC] Disable vector types when not
supported by subtarget features (authored by lei).
Repository:
rG LLVM Github Monorepo
lei updated this revision to Diff 376969.
lei added a comment.
address line comment and update tc to reflect new behaviour.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109178/new/
https://reviews.llvm.org/D109178
Files:
amyk accepted this revision.
amyk added a comment.
Overall LGTM.
Comment at: clang/test/CodeGen/builtins-ppc-int128.c:7
+// RUN: -triple powerpc64le-unknown-unknown -target-cpu pwr8 \
+// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109178/new/
https://reviews.llvm.org/D109178
lei updated this revision to Diff 375360.
lei added a comment.
Address review comments and add handling for vector long types without vsx.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109178/new/
https://reviews.llvm.org/D109178
Files:
nemanjai added a comment.
It is not clear what this patch will do with `vector [[un]signed] long`. This
is currently deprecated but still works - and we don't want it to work with no
VSX.
Comment at: clang/lib/Headers/altivec.h:8881
}
#endif
This file is
lei added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-int128.c:4
+// RUN: -triple powerpc64-unknown-unknown -target-cpu pwr8 \
+// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s
+// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx
NeHuang added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-int128.c:4
+// RUN: -triple powerpc64-unknown-unknown -target-cpu pwr8 \
+// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s
+// RUN: %clang_cc1 -target-feature +altivec -target-feature
lei updated this revision to Diff 370349.
lei added a comment.
fix spelling in commit message.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109178/new/
https://reviews.llvm.org/D109178
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
lei created this revision.
lei added reviewers: hubert.reinterpretcast, nemanjai, power-llvm-team.
Herald added a subscriber: shchenz.
lei requested review of this revision.
Herald added a project: clang.
Update clang to treat vector unsigned long long and friends as invalid
for AlttiVec without
10 matches
Mail list logo
