[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny accepted this revision. jdenny added a comment. LGTM. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing list

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. > I probably won't get to it today, but I can work on it later. Sure, take your time. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. In D109255#2983063 , @jsji wrote: > In D109255#2983052 , @ABataev wrote: > >> In D109255#2983017 , @jdenny wrote: >> >>> This test is meant to

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370663. jsji added a comment. use `_cc1` for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983052 , @ABataev wrote: > In D109255#2983017 , @jdenny wrote: > >> This test is meant to check that the driver processes these options >> correctly. -cc1 isn't the driver and

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. @ABataev Is this still OK for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing list

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

ABataev added a comment. In D109255#2983017 , @jdenny wrote: > This test is meant to check that the driver processes these options > correctly. -cc1 isn't the driver and often ignores either the positive or > negative version of an option. Better not

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370658. jsji added a comment. Use driver + -fsyntax-only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. In D109255#2983018 , @jsji wrote: > In D109255#2983017 , @jdenny wrote: > >> This test is meant to check that the driver processes these options >> correctly. -cc1 isn't the driver and

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983017 , @jdenny wrote: > This test is meant to check that the driver processes these options > correctly. -cc1 isn't the driver and often ignores either the positive or > negative version of an option. OK, I can

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. This test is meant to check that the driver processes these options correctly. -cc1 isn't the driver and often ignores either the positive or negative version of an option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983002 , @ABataev wrote: > I think we can use just `clang_cc1` here instead of `%clang -c` Good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370653. jsji added a comment. Use clang_cc1 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c Index:

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

ABataev added a comment. I think we can use just `clang_cc1` here instead of `%clang -c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji created this revision. jsji added reviewers: jdenny, ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. jsji requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The test driver-fopenmp-extensions.c is failing on