This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3dbcea8b957a: Reland [clang] Check unsupported types in
expressions (authored by asavonic).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
asavonic updated this revision to Diff 373531.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109315/new/
https://reviews.llvm.org/D109315
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
asavonic reopened this revision.
asavonic added a comment.
This revision is now accepted and ready to land.
This is weird... Buildbot reported that `lock/omp_init_lock.c` test
crashed with SIGSEGV, but I cannot reproduce this on my machine.
I added a check for a null QualType; not sure if it
This revision was automatically updated to reflect the committed changes.
Closed by commit rGec6c847179fd: [clang] Check unsupported types in expressions
(authored by asavonic).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109315/new/
Fznamznon accepted this revision.
Fznamznon added a comment.
LGTM, thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109315/new/
https://reviews.llvm.org/D109315
___
cfe-commits mailing list
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, let's wait for @Fznamznon though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109315/new/
https://reviews.llvm.org/D109315
asavonic updated this revision to Diff 371912.
asavonic added a comment.
Rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109315/new/
https://reviews.llvm.org/D109315
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
asavonic updated this revision to Diff 371693.
asavonic added a comment.
- Reworded the diagnostic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109315/new/
https://reviews.llvm.org/D109315
Files:
asavonic added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10687
def err_device_unsupported_type
-: Error<"%0 requires %select{|%2 bit size}1 %3 type support, but device "
-"'%4' does not support it">;
+: Error<"%select{|%1
Fznamznon added a comment.
No objections, just a couple of minors.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10687
def err_device_unsupported_type
-: Error<"%0 requires %select{|%2 bit size}1 %3 type support, but device "
-"'%4' does not
asavonic created this revision.
asavonic added reviewers: erichkeane, Fznamznon.
asavonic requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
The patch adds diagnostics for cases like:
float F3 =
11 matches
Mail list logo