[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#3018830 , @ldionne wrote: > In D109408#2996128 , @zhouyizhou > wrote: > >> In D109408#2996092 , @Quuxplusone >> wrote: >> >>> I

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

ldionne added a comment. In D109408#2996128 , @zhouyizhou wrote: > In D109408#2996092 , @Quuxplusone > wrote: > >> I was going to land this just now, but then realized that I've lost the >> thread of why we're

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2996092 , @Quuxplusone wrote: > I was going to land this just now, but then realized that I've lost the > thread of why we're doing most of this. Why are we touching > clang/test/SemaCXX/? So I'm going to land

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e91666e2864: [libcxxabi] NFC: fix incorrect indentation of braces (authored by zhouyizhou, committed by arthur.j.odwyer). Changed prior to commit:

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

Quuxplusone added a comment. I was going to land this just now, but then realized that I've lost the thread of why we're doing most of this. Why are we touching clang/test/SemaCXX/? So I'm going to land just the fixing of the curly braces in libcxxabi/src/. Comment at:

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. Hi, I have no write access to LLVM, can you commit D109408 for me? Thanks a lot Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109408/new/ https://reviews.llvm.org/D109408

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2988417 , @ldionne wrote: > FWIW, I dislike that we don't indent stuff at all inside namespaces -- often > I find it useful to indent things inside short-lived namespaces. But let's go > for simplicity and

Re: [PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

Hi， On Wed, Sep 8, 2021 at 10:01 AM zhouyizhou via Phabricator wrote: > > zhouyizhou added a comment. > > In D109408#2988417 , @ldionne wrote: > > > FWIW, I dislike that we don't indent stuff at all inside namespaces -- > > often I find it useful to

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2988417 , @ldionne wrote: > FWIW, I dislike that we don't indent stuff at all inside namespaces -- often > I find it useful to indent things inside short-lived namespaces. But let's go > for simplicity and

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. FWIW, I dislike that we don't indent stuff at all inside namespaces -- often I find it useful to indent things inside short-lived namespaces. But let's go for simplicity and consistency.

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

Quuxplusone added inline comments. Comment at: libcxxabi/src/cxa_exception_storage.cpp:102 } } +} // namespace __cxxabiv1 LGTM, FWIW. It's surprising that clang-format adds `} // namespace foo` closing comments, but doesn't add `} // extern "C"` closing

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou created this revision. zhouyizhou added a reviewer: libcxx-commits. zhouyizhou requested review of this revision. Herald added projects: clang, libc++abi. Herald added a subscriber: cfe-commits. Herald added a reviewer: libc++abi. Some functions in cxa_exception_storage.cpp have