[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf7cd664f3fd: [analyzer] Check for std::__addressof for inner pointer checker (authored by alishuja, committed by steakhal). Repository: rG LLVM

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

alishuja accepted this revision. alishuja added a comment. @steakhal yes please go ahead, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109467/new/ https://reviews.llvm.org/D109467 ___

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

steakhal added a comment. @alishuja, Shall I submit this patch with `--author="Ali Shuja Siddiqui "` (thus on your behalf) ? The LLVM DeveloperPolicy mandates me for asking permission. Repository: rG LLVM Github Monorepo

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109467/new/ https://reviews.llvm.org/D109467

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

steakhal updated this revision to Diff 425139. steakhal edited the summary of this revision. steakhal added a comment. - rebased (now using `matchesAny(...)` - added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109467/new/

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

steakhal commandeered this revision. steakhal edited reviewers, added: alishuja; removed: steakhal. steakhal added a comment. Herald added a reviewer: Szelethus. Herald added a project: All. I'll finish this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

NoQ added a comment. Thanks! Can you add a regression test for this, like D99260 does in `test/Analysis/inner-pointer.cpp`? We typically want all commits to have associated test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

alishuja created this revision. alishuja added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov. Herald added subscribers: manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. alishuja requested review of this revision. Herald added a