lattner added a comment.
> What is a "keep constructor"?
Good question, I'm not sure. I think I meant to say "key constructors".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109483/new/
https://reviews.llvm.org/D109483
_
foad added a comment.
What is a "keep constructor"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109483/new/
https://reviews.llvm.org/D109483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
lattner added a comment.
I'll take care of the DAG.getAllOnesConstant change, but i'd appreciate it if
you could look at the NOT cases. Running tests on the DAG.getAllOnesConstant
patch now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109483/ne
lattner added a comment.
Thank you for the detailed review Craig!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109483/new/
https://reviews.llvm.org/D109483
___
cfe-commits mailing list
cfe-commits@lists
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109483/new/
https://reviews.llvm.org/D109483
___
lattner added inline comments.
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3243
"Don't know how to expand this subtraction!");
-Tmp1 = DAG.getNode(ISD::XOR, dl, VT, Node->getOperand(1),
- DAG.getConstant(APInt::getAllOnesValue(VT.getSiz
craig.topper added a comment.
I think I read this patch too closely. I'll leave it up to you how much of this
you want to do.
Comment at: llvm/include/llvm/IR/Constants.h:206
/// Determine if the value is all ones.
bool isMinusOne() const { return Val.isAllOnesValue(); }
lattner marked an inline comment as done.
lattner added inline comments.
Comment at: llvm/include/llvm/ADT/APInt.h:384
/// value for the APInt's bit width.
bool isMaxValue() const { return isAllOnesValue(); }
craig.topper wrote:
> isAllOnes()?
Yep, good c
craig.topper added inline comments.
Comment at: llvm/include/llvm/ADT/APInt.h:384
/// value for the APInt's bit width.
bool isMaxValue() const { return isAllOnesValue(); }
isAllOnes()?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
lattner added a comment.
This patch has a lot of noise, the important part is APInt.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109483/new/
https://reviews.llvm.org/D109483
___
cfe-commits mailing li
10 matches
Mail list logo