[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov updated this revision to Diff 384929. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109496/new/ https://reviews.llvm.org/D109496 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov updated this revision to Diff 384873. mizvekov edited the summary of this revision. mizvekov added a comment. This revision is now accepted and ready to land. Implement workaround. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109496/new/

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. In D109496#3103978 , @mizvekov wrote: > Feel free to revert it if this is blocking you. I don't seem to find a way to > do it via web interface, so I need more time to have access to a machine that > can do it I will revert it s

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. In D109496#3103963 , @mizvekov wrote: > Thanks for reporting this! > > This change in the standard was worked a long time ago, and there was some > expectation that there would be follow up work to add new partial ordering > rule

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov added a comment. Feel free to revert it if this is blocking you. I don't seem to find a way to do it via web interface, so I need more time to have access to a machine that can do it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109496/ne

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov added a comment. Thanks for reporting this! This change in the standard was worked a long time ago, and there was some expectation that there would be follow up work to add new partial ordering rules so that reasonable code would keep working. But the person behind that effort stopped

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. This caused regression in Thrust: /long_pathname_so_that_rpms_can_package_the_debug_info/data/driver/rocThrust/thrust/../thrust/detail/type_traits/pointer_traits.h:178:20: error: ambiguous partial specializations of 'pointer_element>' typedef typename pointer_elem

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d7fba5f95f0: [clang] deprecate frelaxed-template-template-args, make it on by default (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov updated this revision to Diff 382762. mizvekov added a comment. rebase, one last CI run. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109496/new/ https://reviews.llvm.org/D109496 Files: clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, let's land this and see how it goes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109496/new/ https://reviews.llvm.org/D109496 ___

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov updated this revision to Diff 376046. mizvekov added a comment. - Clarify that P0522 was implemented in Clang 4, explain in footnote. - Add DR link. - C++17 section goes all green, so we fold it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

rsmith added inline comments. Comment at: clang/www/cxx_status.html:817 https://wg21.link/p0522r0";>P0522R0 - Partial (10) + Clang 14 We should list this as implemented in Clang 4, with a footnote saying that until Clang 14 you need to pas

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov created this revision. Herald added subscribers: dexonsmith, dang. mizvekov updated this revision to Diff 371538. mizvekov edited the summary of this revision. mizvekov added a comment. mizvekov updated this revision to Diff 371539. mizvekov edited the summary of this revision. mizvekov up