[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299b5d420df1: [CSSPGO] Enable pseudo probe instrumentation in O0 mode. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei accepted this revision. wenlei added a comment. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531 ___ cfe-commits mailing list

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1930 + // mixed with an O0 prelink and an O2 postlink. Loading a sample profile in + // the postlink will require pseudo probe instrumentation in the prelink. + if (PGOOpt &&

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei added a comment. > More specifically, with the following command, both cc1 and lld will run in > default mode, which is -O0 for cc1 and -O2 for lld. > > clang -flto 1.cpp -v -fuse-ld=lld I'm wondering is this the expected behavior or an oversight of pass pipeline setup? In what

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wmi accepted this revision. wmi added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy updated this revision to Diff 371942. hoy added a comment. Updating D109531 : [CSSPGO] Enable pseudo probe instrumentation in O0 mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2994823 , @wmi wrote: > In D109531#2993484 , @hoy wrote: > >> In D109531#2993394 , @wmi wrote: >> >>> In D109531#2992721

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wmi added a comment. In D109531#2993484 , @hoy wrote: > In D109531#2993394 , @wmi wrote: > >> In D109531#2992721 , @hoy wrote: >> >>> In D109531#2992702

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

spupyrev added a comment. In D109531#2993394 , @wmi wrote: > In D109531#2992721 , @hoy wrote: > >> In D109531#2992702 , @wenlei wrote: >> >>> The change makes sense given

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2993394 , @wmi wrote: > In D109531#2992721 , @hoy wrote: > >> In D109531#2992702 , @wenlei wrote: >> >>> The change makes sense given

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wmi added a comment. In D109531#2992721 , @hoy wrote: > In D109531#2992702 , @wenlei wrote: > >> The change makes sense given instr PGO also happens for O0. But practically, >> if a file is being built with O0,

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2992702 , @wenlei wrote: > The change makes sense given instr PGO also happens for O0. But practically, > if a file is being built with O0, do we care about its profile given we're > not really optimizing it anyways?

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei added a comment. The change makes sense given instr PGO also happens for O0. But practically, if a file is being built with O0, do we care about its profile given we're not really optimizing it anyways? Functions from O0 modules are not supposed to be inlined into O1

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wlei accepted this revision. wlei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy created this revision. Herald added subscribers: modimo, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Pseudo probe instrumentation was missing from O0 build. It is needed in cases where some