[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D109544#2996913 , @mgorny wrote: > I'm sorry, it seems to have been caused by ccache. After clearing the cache, > I can't reproduce anymore. The problem is that clang-ast-dump has incomplete dependences and sometimes

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-13 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. I'm sorry, it seems to have been caused by ccache. After clearing the cache, I can't reproduce anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-13 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. This change causes `clang-ast-dump` to segfault for me while building clang: [399/399] ASTNodeAPI.json FAILED: tools/clang/lib/Tooling/ASTNodeAPI.json /home/mgorny/git/llvm-project/build/tools/clang/lib/Tooling/ASTNodeAPI.json cd

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-10 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29b44ca896e7: [OpenMP] Add flag for setting debug in the offloading device (authored by jhuber6). Changed prior to commit:

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-10 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 371914. jhuber6 added a comment. Adding constant to `llvm.used`. This is most likely easier than dealing with weak external linkage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-09 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 371772. jhuber6 added a comment. Adding global regex to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files:

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-09 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 371740. jhuber6 added a comment. Forgot to format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-09 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 371737. jhuber6 added a comment. Addressing Comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-09 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3895 + Opts.OpenMPTargetDebug = 1; + } + CUDANumSMs? Don't check for NVPTX/AMDGCN but only if the new runtime is used, if not emit a warning that the flag is useless

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

2021-09-09 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: dexonsmith, dang, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch