[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG966f24e5a62a: [clang-format] Add a BlockIndent option to AlignAfterOpenBracket (authored by csmulhern, committed by HazardyKnusperkeks). Changed

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. In D109557#3247167 , @HazardyKnusperkeks wrote: > Could you please rebase the patch? I promise I will commit it **very** > shortly afterwards. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 400435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. Could you please rebase the patch? I promise I will commit it **very** shortly afterwards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3242274 , @fdwr wrote: >> I think no one just had thought about it. :) > > @HazardyKnusperkeks Happy new year. Just in case it gets forgotten, I'm > squeaking on behalf of a few stackoverflowers 

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

fdwr added a comment. > I think no one just had thought about it. :) @HazardyKnusperkeks Happy new year. Just in case it gets forgotten, I'm squeaking on behalf of a few stackoverflowers  (#52158077 ,

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. Actually no. I think no one just had thought about it. :) I can try to commit it next week, this one I'm rather busy. Maybe someone else might do it before that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. Is there anything outstanding you'd like me to address, or can we move ahead with committing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern marked an inline comment as done. csmulhern added a comment. I don't have commit access, so please submit this change on my behalf. Thanks for all your help on landing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern marked 4 inline comments as done. csmulhern added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:951 + if (PreviousNonComment && PreviousNonComment->is(tok::l_paren)) { +State.Stack.back().BreakBeforeClosingParen =

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 387025. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:951 + if (PreviousNonComment && PreviousNonComment->is(tok::l_paren)) { +State.Stack.back().BreakBeforeClosingParen = HazardyKnusperkeks wrote: > Remove the braces I

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3066854 , @csmulhern wrote: > In D109557#3063681 , > @MyDeveloperDay wrote: > >> Personally I'm not convinced there wouldn't be people who want this for >>

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. Any further feedback on the latest iteration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 381974. csmulhern marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:227 correctly places the opening brace according to ``BraceWrapping.AfterEnum``. +- Option ``AlignAfterOpenBracket: BlockIndent`` has been added. If set, it will + always break after an open

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 381765. csmulhern added a comment. Absent feedback, I have gone ahead and added a BlockIndent option to AlignAfterOpenBracket. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/