[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2998727 , @csmulhern wrote: > In D109557#2998213 , > @HazardyKnusperkeks wrote: > >> With context he meant the diff context. >>

[PATCH] D109557: Adds an AlignCloseBracket option

MyDeveloperDay added a comment. This isn't really `AlignCloseBracket` but `BreakBeforeClosingParen` isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern added a comment. In D109557#2998213 , @HazardyKnusperkeks wrote: > With context he meant the diff context. > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Ah sorry about that. Done. In D109557#2998226

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern updated this revision to Diff 372364. csmulhern added a comment. Adds more context to the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. You state in the documentation that it is also for angle brackets and more, but there are no test cases for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2997899 , @csmulhern wrote: > I've added more information to my original message. Please let me know if > further context is desired. With context he meant the diff context.

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern added a comment. I've added more information to my original message. Please let me know if further context is desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109557: Adds an AlignCloseBracket option

MyDeveloperDay added a comment. Please resubmit the patch with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern created this revision. csmulhern added a reviewer: MyDeveloperDay. csmulhern requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This style can be used to control the alignment of closing brackets. For prior work on a similar