kamaub marked an inline comment as done.
kamaub added a comment.
Updated an existing test for the backend with pwr8 and pwr9 be/le targets
during commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109599/new/
https://reviews.llvm.org/D109599
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8737c74fab3a: [PowerPC][MMA] Allow MMA builtin types in
pre-P10 compilation units (authored by kamaub).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM as long as you add the back end test.
Comment at: clang/test/CodeGen/ppc-mma-types.c:2
// NOTE: Assertions have been autogenerated by
kamaub updated this revision to Diff 376300.
kamaub added a comment.
Rebasing this patch and addressing review comments
An upstream commit removed the need for this patch to modify a few
test cases so it has been rebased to remain up-to-date, also addressing
review comments.
Repository:
rG
NeHuang added inline comments.
Comment at: clang/test/Sema/ppc-mma-builtins.c:1
+// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown -target-cpu pwr10 \
+// RUN: -target-feature -mma -fsyntax-only %s -verify
can you please add `// REQUIRES:
kamaub updated this revision to Diff 371954.
kamaub added a comment.
The condition for failing semantic chequing on mma builtins was incorrect,
updating this patch to correctly check the semantics and associated testing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kamaub created this revision.
kamaub added reviewers: PowerPC, nemanjai, lei, saghir, stefanp.
Herald added subscribers: steven.zhang, shchenz, kbarton.
kamaub requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch allows the use
