[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

2021-09-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I uploaded D109727 to clean up suse related `*Triples` elements in `CollectLibDirsAndTriples`. The long-term plan is to remove the `*Triples` variables entirely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

2021-09-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Haven't looked closely at this particular commit, but I think hard coding the detected triples is almost always a bad idea. See https://reviews.llvm.org/D63497#2993662 for a longer comment. The proper way is (1) making sure CMake `LLVM_DEFAULT_TARGET_TRIPLE` is correct

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

2021-09-13 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added reviewers: serge-sans-paille, MaskRay, mgorny. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. The GCCInstallationDetector has a list of gcc triples to search for when trying to find a val