This revision was automatically updated to reflect the committed changes.
Closed by commit rG544d89e847d4: [OpenCL] Add atomic_half type builtins
(authored by svenvh).
Changed prior to commit:
https://reviews.llvm.org/D109740?vs=376467=378938#toc
Repository:
rG LLVM Github Monorepo
CHANGES
haonanya added a comment.
Hi, svenvh. Thanks for your review.
Could you please help to submit the patch if there are no more inputs?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109740/new/
https://reviews.llvm.org/D109740
___
cfe-commits
svenvh accepted this revision.
svenvh added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109740/new/
https://reviews.llvm.org/D109740
___
cfe-commits mailing list
haonanya updated this revision to Diff 376467.
haonanya added a comment.
Fix format issue
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109740/new/
https://reviews.llvm.org/D109740
Files:
clang/lib/Headers/opencl-c.h
clang/lib/Sema/OpenCLBuiltins.td
clang/lib/Sema/Sema.cpp
svenvh added a comment.
Looks good at a first quick glance, but please fix the formatting errors that
are reported on the lines that you are adding.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109740/new/
https://reviews.llvm.org/D109740
haonanya created this revision.
haonanya added reviewers: svenvh, Anastasia.
haonanya added a project: clang.
Herald added subscribers: ldrumm, yaxunl.
haonanya requested review of this revision.
Herald added a subscriber: cfe-commits.
Add atomic_half types and builtins operating on the types
