[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

2021-09-27 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75f0194d3d25: [Driver] Remove confusing *-linux-android detection with non-android --target= (authored by MaskRay). Repository: rG LLVM Github

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

2021-09-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 375383. MaskRay edited the summary of this revision. MaskRay added a reverted change: D53463: [Driver] allow Android triples to alias for non Android targets. MaskRay added a comment. revert D53463 Repository: rG LLVM

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

2021-09-27 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Sorry, I missed the email for this code review, let me check my filters aren't too agressive. > The Android kernel build does not use the Android triple. That's no longer the case, so we might as well just wholesale revert D53463

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

2021-09-23 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added a reviewer: nickdesaulniers. pirama added a subscriber: nickdesaulniers. pirama added a comment. @nickdesaulniers I presume this is still necessary? See https://reviews.llvm.org/D53463 for why we added this. (The Android kernel build does not use the Android triple.)

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

2021-09-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. You may need to check whether the Android clang has correct `clang -dumpmachine`. If not, specify `LLVM_HOST_TRIPLE` explicitly in CMake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110379/new/

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

2021-09-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: pirama, srhines. Herald added subscribers: danielkiss, kristof.beyls. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These values allow, for example, `--target=aarch64` and