[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-10-01 Thread Orlando Cazalet-Hyams via Phabricator via cfe-commits
Orlando added a comment. In D110783#3036403 , @thakis wrote: >> Hopefully better after ec4a82286674c44c9216e9585235b0fa5df4ae9f >> > > Your bot cycled green after that change: >

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-10-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. > Hopefully better after ec4a82286674c44c9216e9585235b0fa5df4ae9f > Your bot cycled green after that change: https://lab.llvm.org/buildbot/#/builders/139/builds/10976 Repository: rG LLVM Github

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-10-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D110783#3035158 , @dyung wrote: > Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot > after your change. Can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/10939 Hopefully

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-09-30 Thread Wolfgang Pieb via Phabricator via cfe-commits
wolfgangp added a comment. In D110783#3035158 , @dyung wrote: > Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot > after your change. Can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/10939 Seems

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-09-30 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot after your change. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/10939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-09-30 Thread Nico Weber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dfbe9b0aeb6: [clang] Make crash reproducer work with clang-cl (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-09-30 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks for digging into this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110783/new/ https://reviews.llvm.org/D110783 ___

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-09-29 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. thakis added a project: clang. thakis requested review of this revision. When clang crashes, it writes a standalone source file and shell script to reproduce the crash. The Driver used to set `Mode = CPPMode` in