[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

probinson added a comment. Response files should work for all our tools, I think? Keeping the option is fine with me, but the description needs some improvement. @ychen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111000/new/

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

HazardyKnusperkeks added a comment. One does not need to remove this, when adding response file support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111000/new/ https://reviews.llvm.org/D111000 ___

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

MyDeveloperDay added a comment. The use of a response file was actually new to me, I suspect it isn't widely know about, but yes in theory it could be used. As this feature has been landed for sometime, I'm not included to remove it, there could be other people using it. Repository: rG

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

probinson added a comment. In D111000#3822354 , @ychen wrote: > It is possible to just use `clang-format @response.txt`? That should also > invoke the executable once. It's true that whatever file you're handing to `--files` could just as easily be

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

ychen added a comment. Herald added subscribers: pcwang-thead, abrachet. Herald added a reviewer: ThomasRaoux. Herald added a project: All. It is possible to just use `clang-format @response.txt`? That should also invoke the executable once. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

MyDeveloperDay added a comment. In D111000#3038308 , @HazardyKnusperkeks wrote: > Basically okay, I would have made 3 commits out of it: > > 1. Add the function to clang-format > 2. The code clean up of the python script > 3. The additional file

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Basically okay, I would have made 3 commits out of it: 1. Add the function to clang-format 2. The code clean up of the python script 3. The additional file generation