This revision was automatically updated to reflect the committed changes.
Closed by commit rGb4b9f9b4b3cf: [PowerPC] Emit dcbt and dcbtst in place of
their extended mnemonics on AIX (authored by Conanap).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
nemanjai accepted this revision.
nemanjai added a comment.
LGTM. This is already approved, but just wanted to indicate that I think the
comments were addressed adequately.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111258/new/
https://reviews.llvm.org/D111258
Conanap updated this revision to Diff 378015.
Conanap marked 2 inline comments as done.
Conanap added a comment.
Added mordern assembler check
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111258/new/
https://reviews.llvm.org/D111258
Files:
nemanjai added a comment.
Please change the condition as Jinsong suggested and change the leading comment
to:
// On AIX, only emit the extended mnemonics for dcbt and dcbtst if
// the "modern assembler" is available.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jsji accepted this revision as: jsji.
jsji added a comment.
This revision is now accepted and ready to land.
Thanks for working on this.
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:161
// where th can be omitted when it is 0. dcbtst is the same.
-
Conanap created this revision.
Conanap added reviewers: nemanjai, jsji, PowerPC.
Conanap added projects: clang, LLVM, PowerPC.
Herald added subscribers: kbarton, hiraditya.
Conanap requested review of this revision.
On AIX, the system assembler does not support the extended mnemonics
`dcbtt` and
