[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur added a comment. Thanks, this fixed the errors introduced in D105191 : http://meinersbur.de:8011/#/builders/1/builds/1594 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:617 + // Find nvlink and pass it as "--nvlink-command=" argument of clang-nvlink-wrapper. + auto NvlinkBin = getToolChain().GetProgramPath("nvlink"); + const char *NvlinkPath =

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGf56548829c4c: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378979. saiislam added a comment. clang-format(ed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/ https://reviews.llvm.org/D111488 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378978. saiislam marked 5 inline comments as done. saiislam added a comment. Thanks, Michael and Artem! 1. Changed nvlink-command to nvlink-path. 2. Answered queries and done refactoring as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:620 + Args.MakeArgString(Twine("--nvlink-command=" + NvlinkBin)); + CmdArgs.push_back(NvlinkPath); + Nit: the variables above are used only once. It would be fine to just

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Some nitpicks, but it fixes the build, so LGTM. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:617 + // Find nvlink and pass it as "--nvlink-command=" argument of

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378633. saiislam added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/ https://reviews.llvm.org/D111488 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378630. saiislam marked 4 inline comments as done. saiislam added a comment. 1. Changed the option from path to nvlink-command. 2. Command line arguments are now parsed using proper API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thanks for the path, but command line parsing should be done properly. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:50 +static

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam created this revision. saiislam added reviewers: Meinersbur, ye-luo, JonChesterfield. saiislam requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Added support of a "--path=" option in