[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

probinson added a comment. In D111587#3383684 , @keith wrote: > You're right it's version 5 not 4, maybe the issue is that some platforms > (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 > because passing 6 also reproduces,

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith abandoned this revision. keith added a comment. There were 2 competing revisions for this bug fix, I landed https://reviews.llvm.org/D121663 instead since it sounds like having an empty `directory` is more correct in this case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. You're right it's version 5 not 4, maybe the issue is that some platforms (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 because passing 6 also reproduces, but I didn't also try 5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

probinson added a comment. In D111587#3382834 , @keith wrote: > I actually mean dwarf 6, which appears to be partially implemented according > to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html > > I discovered the issue from the failed

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added inline comments. Comment at: clang/test/Modules/module-debuginfo-prefix.m:24 -// Dir should always be empty, but on Windows we can't recognize /var -// as being an absolute path. -// CHECK: !DIFile(filename: "/OVERRIDE/DebugObjC.h", directory: "{{()|(.*:.*)}}")

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. I actually mean dwarf 6, which appears to be partially implemented according to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html I discovered the issue from the failed tests on https://reviews.llvm.org/D113718 where you can see the test output contains a

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

probinson added a comment. In D111587#3381369 , @keith wrote: > Fix tests with dwarf 6 Do you mean dwarf 5 here? There is no v6 yet. Comment at: clang/test/Modules/module-debuginfo-prefix.m:24 -// Dir should always be empty, but

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415307. keith added a comment. Fix tests with dwarf 6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415292. keith added a comment. Herald added a project: All. Update subsitutions with slashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files:

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411926. keith added a comment. Fix parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411923. keith added a comment. Update test with new variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411576. keith added a comment. Update test with new specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. This broke tests on windows (see the new parent revisions in the stack) otherwise the actual change's behavior, outside of the tests, is unchanged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith created this revision. keith added a reviewer: probinson. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed an absolute path to clang, where only part of the path to the file was remapped, it would result